This repository was archived by the owner on May 29, 2019. It is now read-only.
Check for altInputFormats to be defined and an array before using it#6511
Open
gigadie wants to merge 1 commit intoangular-ui:masterfrom
gigadie:patch-1
Open
Check for altInputFormats to be defined and an array before using it#6511gigadie wants to merge 1 commit intoangular-ui:masterfrom gigadie:patch-1
gigadie wants to merge 1 commit intoangular-ui:masterfrom
gigadie:patch-1
Conversation
If the user wrongly sets a property which is undefined for the attribute alt-input-formats, this will cause an exception to be thrown when evaluating the viewValue in the method parseDateString: "Cannot read property 'length' of undefined". Checking for its existence and if it's an array or not prevents the exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user wrongly sets a property which is undefined for the attribute
alt-input-formats, this will cause an exception to be thrown when evaluating theviewValuein the methodparseDateString."Cannot read property 'length' of undefined".Checking for its existence and if it's an array or not prevents the exception.